Skip to content

Fix: prepare works even if nothing except tp specified (rare) #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

S1ro1
Copy link
Member

@S1ro1 S1ro1 commented Aug 4, 2025

If we only had TP specified, the training would probably be still correct, though the optimizer/dataloader wouldn't be accelerator prepared (in some cases). This was and is a rare case, as pure TP is not fully supported yet anyway. Though this PR fixes atleast this.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants