[FSDP2] Cast model to uniform dtype before fully_shard to fix mixed-dtype AssertionError#3985
Open
roycho96 wants to merge 2 commits intohuggingface:mainfrom
Open
[FSDP2] Cast model to uniform dtype before fully_shard to fix mixed-dtype AssertionError#3985roycho96 wants to merge 2 commits intohuggingface:mainfrom
roycho96 wants to merge 2 commits intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When
mixed_precisionis enabled, casts model parameters to uniform dtype beforefully_shard()to prevent_init_mp_dtypes()AssertionError.Problem
FSDP2's
_init_mp_dtypes()requires uniformorig_dtypeacross all trainable parameters in a param group. With mixed dtypes, the first forward call crashes:FSDP2's
fsdp2_prepare_model()currently passes the mixed-dtype model directly tofully_shard()without normalizing dtypes.Fix
Cast all parameters to the mixed precision
param_dtypebeforefully_shard(), aftermodel_has_params4bitdetection. Params4bit models are skipped to avoid destroying quantized weights.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@SunMarc