fix: Ensure deterministic height adjustment in handleKeydown#1863
Closed
calycekr wants to merge 1 commit intohuggingface:mainfrom
Closed
fix: Ensure deterministic height adjustment in handleKeydown#1863calycekr wants to merge 1 commit intohuggingface:mainfrom
calycekr wants to merge 1 commit intohuggingface:mainfrom
Conversation
Improved the existing logic by `tick().then()` in `handleKeydown` ensuring DOM updates are applied after the submit event is dispatched.
rtrompier
force-pushed
the
main
branch
4 times, most recently
from
d147fec to
4d98b15
Compare
Collaborator
|
ty reworked it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the fix introduced in #1854 by ensuring the textarea height adjustment completes deterministically after the submit event is dispatched.
Previously, there was a race condition where the textarea height adjustment could be scheduled but not applied before submission, leading to inconsistent UI behavior.
Changes:
tick().then()inhandleKeydownensuring DOM updates are applied after the submit event is dispatched.Fixes: #1854