Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lock permission #7361

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix lock permission #7361

wants to merge 2 commits into from

Conversation

cih9088
Copy link

@cih9088 cih9088 commented Jan 7, 2025

All files except lock file have proper permission obeying ACL property if it is set.

If the cache directory has ACL property, it should be respected instead of just using umask for permission.
To fix it, just create a lock file and pass the created mode.

By creating a lock file with touch() before FileLock create it with mode,

  • if ACL is not set, same as before
  • if ACL is set, ACL is respected

If it is acceptable, it should be also applied to huggingface_hub I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant