Update _dill.py to use co_linetable for Python 3.10+ in place of co_lnotab
#7609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the handling of code object line information to address the deprecation of co_lnotab in Python 3.10+ by conditionally using an alternative attribute.
- Replace co_lnotab with co_linetable in multiple functions.
- Remove deprecation warnings in Python 3.12 by conditionally checking sys.version_info.
Comments suppressed due to low confidence (1)
src/datasets/utils/_dill.py:272
- The PR title mentions using 'co_lines' instead of 'co_lnotab', but the changes use 'co_linetable'. Please verify that 'co_linetable' is the intended attribute for Python 3.10+ to ensure consistency with the proposed update.
obj.co_linetable if sys.version_info >= (3, 10) else obj.co_lnotab,
|
not 100% sure either, I tried removing unnecessary checks - let me know if they sound good to you otherwise I'll revert |
lhoestq
changed the title
_dill.py to use co_lines for Python 3.10+ in place of co_lnotab_dill.py to use co_linetable for Python 3.10+ in place of co_lnotab
|
I can't reproduce the warning anymore... 🤦🏻♂️ |
|
Ah now I can reproduce!, and I can confirm that the warning is gone when you apply the change in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% about this one, but it seems to be recommended.
Tests pass locally. And the warning is gone with this change.
https://peps.python.org/pep-0626/#backwards-compatibility