Fix spurious label column when directories match split names#7881
Open
neha222222 wants to merge 1 commit intohuggingface:mainfrom
Open
Fix spurious label column when directories match split names#7881neha222222 wants to merge 1 commit intohuggingface:mainfrom
neha222222 wants to merge 1 commit intohuggingface:mainfrom
Conversation
lhoestq
reviewed
Dec 8, 2025
Member
lhoestq
left a comment
There was a problem hiding this comment.
Great ! I think it works great in general but can have weird edge cases, like if the splits are defined with directories that are not the split names, e.g.
- split: train
path: "my-dir/*.png"
- split: test
path: "my-other-dir/*.png"maybe a more robust way could be to check whether each split has exactly one label, and that the labels of every split are different. wdyt ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue - #7880