Add conditional import for pickle5 in unit-2 hands-on#632
Open
bodoque-01 wants to merge 2 commits intohuggingface:mainfrom
Open
Add conditional import for pickle5 in unit-2 hands-on#632bodoque-01 wants to merge 2 commits intohuggingface:mainfrom
bodoque-01 wants to merge 2 commits intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves installation failures when setting up the Unit 2 hands-on exercise requirements. The current
pickle5dependency causes build errors on Python 3.8+, since the package is no longer required for modern Python versions and Google Colab already runs Python 3.10+.In case a student decides to do the hands-on exercise locally instead of doing it in Colab and happens to have a Python version older than 3.8, the PR code will work just as fine because of the dynamic requirement installation based on Python's version being used.
Approach:
pickle5; python_version < "3.8"Testing: