Skip to content

Update GitHub Actions to use Node 20 #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Jun 18, 2024

Currently, we get deprecation warnings when building our docs: https://github.com/huggingface/datasets/actions/runs/9547896244

build / build_main_documentation
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

This PR updates the required GitHub Actions to use Node 20.

@albertvillanova
Copy link
Member Author

There was still one deprecation warning: https://github.com/huggingface/doc-builder/actions/runs/9561218485

integration_doc_build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@albertvillanova
Copy link
Member Author

We are still getting the deprecation warnings: https://github.com/huggingface/datasets/actions/runs/10402495585

build / build_main_documentation
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build / build_main_documentation
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

@coyotte508 coyotte508 merged commit ea8aa6e into huggingface:main Sep 2, 2024
5 checks passed
@albertvillanova
Copy link
Member Author

Thanks for the merge, @coyotte508. 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants