Skip to content

Add Embedding frontend #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
May 6, 2025
Merged

Add Embedding frontend #5

merged 31 commits into from
May 6, 2025

Conversation

mfuntowicz
Copy link
Member

@mfuntowicz mfuntowicz commented May 4, 2025

Summary

This Pull Request introduces enhancements and new functionality to the existing codebase. The changes include the addition of a robust embeddings implementation, XML configurations for integration workflows, and various dependency updates. Some unused or verbose code has been removed for better readability and maintenance.

Main Changes:

Integration Workflow Update:

  • Added a new repository embeddings-sentence-transformers-cpu to the GitHub Actions workflow configuration.

Core Code Enhancements:

  • Defined a new TestError in Rust's error handling for better logging/debugging.

Embeddings Implementation:

  • Introduced a new embeddings module to generate vector representations.
  • Added Python bindings for the embeddings API, complete with utility classes like EmbeddingRequest, EmbeddingResponse, etc.
  • Integrated testing cases for embeddings functionality with detailed scenarios.

Dependency Updates:

  • Upgraded or added dependencies such as rust-numpy, numpy, and timeout utilities in various manifests.
  • Enhanced configuration slots and introduced a debug flag for endpoints.

Code Cleanup:

  • Removed the excessive use of logging instrumentation in specific parts of the Python handler. Simplified redundant or verbose annotations.

Versioning:

  • Updated crate versions and adjusted Python packaging to reflect these changes.

AI generated

@mfuntowicz mfuntowicz requested a review from Hugoch May 6, 2025 12:20
@mfuntowicz mfuntowicz added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit 09ac37b May 6, 2025
12 checks passed
@mfuntowicz mfuntowicz deleted the front-oai-embeddings branch May 8, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants