misc/make-clippy-happier #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request refactors the code to introduce a new type alias for error handling and context-binding in multiple modules. The EndpointResult type is introduced to standardize result types, and RequestWithContext type alias improves clarity for context-bundled requests. Changes primarily impact request handling and endpoint definitions in audio transcription, embeddings, and core logic.
Main Changes
Added EndpointResult and RequestWithContext type aliases for improved readability and standardized error/result handling.
Refactored EndpointContext structures and function signatures to use EndpointResult and RequestWithContext in the hfendpoints-core module.
Updated routes and handlers in audio/transcriptions and embeddings to align with the new type aliases.
Enhanced documentation by including new tags for OpenAPI endpoints (EMBEDDINGS_DESC and EMBEDDINGS_TAG) alongside existing ones.
This refactor simplifies code readability and consistency while preserving functionality.