Bump hf_xet min version to 1.0.0 + make it required dep on 64 bits#2971
Bump hf_xet min version to 1.0.0 + make it required dep on 64 bits#2971hanouticelina merged 28 commits intomainfrom
hf_xet min version to 1.0.0 + make it required dep on 64 bits#2971Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
We might also want to make it a required dependency like this: install_requires = [
"filelock",
...
"hf-xet>=1.0.0,<2.0.0; platform_machine=='x86_64'"
]To be confirmed that it's valid (i.e. that |
There was a problem hiding this comment.
Based on https://huggingface.slack.com/archives/C087TU2FE3G/p1743578935907289?thread_ts=1743535244.936859&cid=C087TU2FE3G (private link)
let's go for having this as required dependency:
"hf-xet>=1.0.0,<2.0.0; platform_machine=='x86_64' or platform_machine=='amd64' or platform_machine=='arm64' or platform_machine=='aarch64'",and
extras["hf_xet"] = ["hf_xet>=1.0.0,<2.0.0"]as optional
(list comes from https://pypi.org/project/hf-xet/#files)
|
made the changes in 1d6a644. so now, |
hf_xet min version to 1.0.0hf_xet min version to 1.0.0 + make it required dep on 64 bits
Wauplin
left a comment
There was a problem hiding this comment.
Let's wait before merging. It looks like hf_xet==1.0.0 is broken on Windows with both Python 3.8 and Python 3.11. I tried with hf_xet<1.0.0 and tests are passing so it has to be something with the new release. Reported in https://huggingface.slack.com/archives/C087TU2FE3G/p1743603382910589?thread_ts=1743535244.936859&cid=C087TU2FE3G (private link) cc @rajatarya
Co-authored-by: Lucain <lucain@huggingface.co>
Wauplin
left a comment
There was a problem hiding this comment.
Windows pipeline to update to remove hf_xet when not needed. Apart from that looks good to me but let's wait for a more reliable CI before merging (currently failing with a lot of 503 unavailable service)
No description provided.