Retry on transient error in download workflow #2976
Merged
+8
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally from @Wauplin on Slack (internal link):
So basically this PR adds a retry mechanism when downloading a file (GET /resolve) or when fetching metadata for a file (HEAD /resolve) if rate limit is reached. Retry after 1s, 2s, 4s, 8s and 8s.
Comments:
HfFileSystem
useshttp_backoff
with retries on 5xx errors but not 429 🤔@julien-c @LysandreJik @hanouticelina any obvious drawback that I missed from retrying on 429 for now?
EDIT: actually HTTP 429 are rare in downloads, that's why we never had one. Problem arose today because of Xet bridge that rate-limited @Vaibhavs10