-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CI Eager/Lazy for Language Modeling #1448
base: main
Are you sure you want to change the base?
Create CI Eager/Lazy for Language Modeling #1448
Conversation
I need an help to catch a "segmentation fault" event like this one (it was the main reason to create this test case)
It doesn't return to main thread and I can't complete the test run |
@emascarenhas this is the test to add to CI suite. Please take a look when you have time. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor quibbles, otherwise looks good to me.
@Chris-Sigopt any idea about this issue? #1448 (comment) |
@Luca-Calabria , Can you make this part of test_examples.py instead of a new file? |
@emascarenhas sure, I can. This actually was a question I would ask to you because I saw similar test cases in other existent files. I'll make the new test as part of test_examples.py |
I have not encountered that particular error message before. Based off the message, my guess would be that some python type coercion is happening incorrectly, which is a problem we've encountered regularly, but that's just a guess. |
@emascarenhas @Chris-Sigopt I moved the new test to test_examples.py as part of Causal Language Modeling test case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Luca-Calabria ,
About adding Eager test, yes I think you should, because that was one of the failures?
Otherwise, code looks good to me. If you add Eager test, I can do a quick re-review. I suppose you ran the test and it worked without issues and you didn't hit the crash from earlier? Please confirm.
@emascarenhas , yep after the fix on command line suggested by @Chris-Sigopt here #1448 (comment) I'm able to run both Lazy and Eager successufully also on older Synapse versions. |
What does this PR do?
Add a test to CI suite to check/validate LLM training/finetuning as Eager and Lazy Mode
How to run it manually:
root@id:~/optimum-habana# GAUDI2_CI=1 RUN_SLOW=1 python -m pytest tests/test_language_modeling_example.py::test_language_modeling_bf16_1x -s -v