Fixing scalings logging test #2042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricLBuehler
commented
Aug 27, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@BenjaminBossan this should be ready for review! |
BenjaminBossan
requested changes
Sep 5, 2024
tests/test_xlora.py
Outdated
| assert torch.isfinite(outputs[: inputs.shape[1] :]).all() | ||
|
|
||
| # TODO: remove the skip when 4.45 is released! | ||
| @pytest.mark.skipif(int(transformers.__version__.split(".")[1]) < 45, reason="Requires transformers >= 4.45") |
There was a problem hiding this comment.
Let's do the version check similar to how we do it here:
Line 1670 in c9f7240
This should be more robust. It requires the import: import packaging.version.
There was a problem hiding this comment.
Sounds good, I just added this to the PR!
BenjaminBossan
approved these changes
Sep 5, 2024
Guy-Bilitski
pushed a commit
to Guy-Bilitski/peft
that referenced
this pull request
May 13, 2025
Fix test for latest transformers, skip for earlier versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.