-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Drop Python 3.9, add 3.13 #2790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Right now, we don't test PEFT with Python 3.13: peft/.github/workflows/tests.yml Line 44 in 20a9829
Our test infrastructure is already strained, so we don't add a 5th Python version. Once Python 3.9 is EOL, which is in October, we'll remove it and add Python 3.13 to the test matrix. That said, I'm pretty sure that PEFT will work with 3.13, but I would only add it as a classifier once it's tested in CI. |
@BenjaminBossan Could I add 3.13 and drop 3.9 in this PR so that it can be merged once 3.9 is out. |
@cyyever We can make this the "Drop Python 3.9, add 3.13" PR. I turned it into a draft, as we only want to merge it in Oct. There are probably more things that could be added for this transition, e.g. removing a lot of |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Okay, so we get the green tick for Ubuntu, but CI fails for MacOS and Windows. Honestly, MacOS is a lost cause at this point and I think it's fine to just exclude it from the test matrix. For Windows, the issue appears to be the low numpy version, which is installed due to this step: peft/.github/workflows/tests.yml Lines 82 to 87 in 20a9829
Based on some testing (#2791), it can probably be removed completely. If not, we can condition it on the Python version. |
@cyyever Would you like to add the changes I proposed above? |
@BenjaminBossan Do you mean removing the section in |
Yes, removing it and also adding an exclusion rule for MacOS + Python 3.13. |
@BenjaminBossan Let's try removing it. |
Signed-off-by: Yuanyuan Chen <[email protected]>
Signed-off-by: Yuanyuan Chen <[email protected]>
Signed-off-by: Yuanyuan Chen <[email protected]>
Generally, this seems to work. The CI is very flaky, merging with/rebasing on the latest main will most likely fix that. Also, let's add an exclusion rule after this line for MacOS + Python 3.13: exclude:
- os: macos-latest
python-version: "3.13" |
Signed-off-by: Yuanyuan Chen <[email protected]>
@BenjaminBossan Done |
Co-authored-by: Benjamin Bossan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR to add Python 3.13 to the list of supported Python versions and remove 3.9. If I understand this table correctly, Python 3.9 is EOL on Oct 1, so we can merge this PR tomorrow :)
No description provided.