-
Notifications
You must be signed in to change notification settings - Fork 2.7k
T5Gemma2 Support #3604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
T5Gemma2 Support #3604
Conversation
|
Hello! This is definitely in the right direction, matching what I would do as well. The only downside is that the T5GemmaConfig doesn't immediately expose the Compared to sentence-transformers/sentence_transformers/models/Transformer.py Lines 287 to 288 in c19c540
I've done some tests, and it looks like this PR works once the I made some small changes, but it won't let me push that into this PR sadly, as I don't have the required permissions on the PR host repository. You can see the commit here: 7b429c8
|
|
I added your changes. I didn't enable commiter push on this PR because I wanted to keep track of things. If you have other changes, let me know and I will make these changes. I would now like to add examples and tests before I take this PR out of draft mode. I would like to implement a full quantization-aware FR-EN biilingual matryoshka training and subsequent ONNX export and OpenVINO ONNX Runtime inference. What do you think? |
|
I forgot |
|
Hi Tom! With the latest commit, loading the model now works:
The code is a mix of your other PRs with what's currently on the |
|
Hi Tom. Or I can just turn over this PR to you so you can pull it and I can make another PR for examples and tests. |
|
Hi Tom! What are your plans for this PR ? Thanks! Vincent |
Hi! As per #3602, here is a WIP just to check if I'm on the right track. If you agree with the general idea, I will write some tests with the t5gemma2 weights. I don't expect you guys to work on the holidays so take your time and get back to me when you can.
-- Vincent