Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move batch, sort_embeddings into backends/candle #321

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Jeadie
Copy link

@Jeadie Jeadie commented Jul 3, 2024

What does this PR do?

  • Change: Moves the functions batch, sort_embeddings backends/candle/tests/ to backends/candle.
  • Motivation: Crates consuming text-embeddings-inference as a dependency (and not as a standalone server) can access these methods.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed.

@Jeadie Jeadie changed the title move batch, sort_embeddings into backends/candle Move batch, sort_embeddings into backends/candle Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant