fix: update WebGPU embedding benchmark to prefer GPUAdapter.info over requestAdapterInfo#1098
Closed
ErichDonGubler wants to merge 2 commits intohuggingface:mainfrom
Closed
fix: update WebGPU embedding benchmark to prefer GPUAdapter.info over requestAdapterInfo#1098ErichDonGubler wants to merge 2 commits intohuggingface:mainfrom
GPUAdapter.info over requestAdapterInfo#1098ErichDonGubler wants to merge 2 commits intohuggingface:mainfrom
Conversation
…er `requestAdapterInfo` Migrates to use the new spec.-compliant way of getting adapter info in WebGPU (see also <microsoft/onnxruntime#21065>). This has been removed by both Chrome and Firefox, so there might be enough reason to simply stop using `requestAdapterInfo`, but I wasn't sure.
…fo over requestAdapterInfo
Author
|
This might not be ready to merge yet, if the main library doesn't yet expose the |
Collaborator
|
Thanks for the heads up! I'm busy migrating all our examples to http://github.com/huggingface/transformers.js-examples, and will update them to use |
Collaborator
|
(closed recently by #1382) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates to use the new spec.-compliant way of getting adapter info in WebGPU (see also microsoft/onnxruntime#21065).
This has been removed by both Chrome and Firefox, so there might be enough reason to simply stop using
requestAdapterInfo, but I wasn't sure.