customize the wasm paths #1250
Merged
customize the wasm paths #1250
+40
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I'll do some additional testing, and hopefully have this included with #1231. |
|
Superseded by #1231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logics to have a better customized
wasmPathssetting. Specifically, the following changes were made:(Safari) Fallback to non ASYNCIFY build of webassembly, because of an OOM issue: 🐛 v3 crashes on iOS and macOS devices due to increasing memory usage #1242
Because of the fallback feature, we need to access file ort-wasm-simd-threaded.mjs and ort-wasm-simd-threaded.wasm, which is not in package
@huggingface/transformers. point toonnxruntime-web.only apply override to
wasmPathswhenenv.backends.onnx.versions.webexists. The only situation that it does not exist is the nodejs build.The feature need to be well tested.