Use custom cache over FSCache if specified #1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if both `useFSCache` and `useCustomCache` env options are set to true (perhaps because `useFSCache` is true by default and the user forgot to unset it), the code defaults to instantiating a FileCache instead of using the custom cache implementation passed in by the user. This commit changes the default to be the custom cache if specified.
|
Thanks! Should we maybe take this one step further and prefer this over browser cache too? (otherwise, similarly, the user would need to disable browser cache before enabling custom cache) |
|
Of course! Totally missed that. 👍🏼 👍🏼 |
If `useCustomCache` is set, try to use the custom cache before falling back to the browser or the fs caches.
Meant to handle cases where the user sets `useFSCache` from an environment that doesn't support `fs`.
|
Possibly outside the scope of this PR, but saw a TODO in the same place about throwing an error on fs cache being unavailable. Added a simple check for fs in my last commit. Seems okay from what I can see, but can revert if not needed right now. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if both
useFSCacheanduseCustomCacheenv options are set to true (perhaps becauseuseFSCacheis true by default and the user forgot to unset it), the code defaults to instantiating a FileCache instead of using the custom cache instance passed in by the user when getting model files. This commit changes the default to be the custom cache if specified.