Check for Canvas API before using instead of environment #1417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1372
The
IS_WEBWORKER_ENV
istrue
for Deno Worker runtime:transformers.js/src/env.js
Line 33 in 699dcb5
So it is not reliable condition to check for HTML/Offscreen-Canvas API usage.
One way to fix it is to go from env-based conditions to feature-based.
If we add Deno condition to exclude Canvas API, it would work for now, but I think it will be broken for Node Workers (nodejs/node#43583) and Bun Web Workers.
Please note that this PR has been tested only with Deno, not other environments. It should be tested further, closed, or used as a starting point.