Closed
Conversation
Collaborator
|
(This was superseded by #1382) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@xenova, here is my idea of a CONTRIBUTING.md
Couple of things to discuss (marked as [TODO] in the file)
I've also seen that 16 of the 1926 tests failed is that a problem? If not we should not enforce the tests in the PR checklist. Otherwise we maybe should look into it
I also had to make some changes to the webpack config. Mainly because the dev-server failed in my setup because of an error (Error: EMFILE: too many open files, watch) and I had to add CORS headers so the test-application can load transformers.js from HTTP without CORS error.
Lastly I think it makes sense to introduce the CONTRIBUTING.md in v4 so prettier works as well.