Type error fixes #1436
Type error fixes #1436
Conversation
merged latest
merged latest
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| */ | ||
| // @ts-expect-error The type of this method is not compatible with the one | ||
| // in the base class. It might be a good idea to fix this. | ||
| // @ts-expect-error The type of this method is not compatible with the one in the base class. |
There was a problem hiding this comment.
ah thanks! Probably why it wasn't being registered correctly.
| "noEmit": false, | ||
| "emitDeclarationOnly": true | ||
| "emitDeclarationOnly": true, | ||
| "esModuleInterop": true |
There was a problem hiding this comment.
what does this do (specifically needed for this PR)? 👀 https://www.typescriptlang.org/tsconfig/#esModuleInterop
There was a problem hiding this comment.
I got an error file investigation this issue:
../types/utils/image.d.ts:140:8 - error TS1259: Module '"/path/transformers.js/node_modules/sharp/lib/index"' can only be default-imported using the 'esModuleInterop' flag
140 import sharp from 'sharp';
The problem is that sharp is using commonJS (require). This will ensure that interop between CommonJS ed es modules works better. As far as I know it doesn't affect runtime behavior. It only helps TypeScript understand CommonJS modules better during type checking and generation.
.gitignore
Outdated
| .DS_STORE | ||
| deno.lock | ||
| .idea | ||
| demo |
There was a problem hiding this comment.
You're right. I removed it.
xenova
changed the title
3 participants
The following errors from #1409 are adressed by this PR:
Closes #1337
Closes #1409