Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to use their own loss functions + deal with prefetching for grad accum #34198

Merged
merged 20 commits into from
Oct 17, 2024
Merged

Enable users to use their own loss functions + deal with prefetching for grad accum #34198

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
57c698f
bookmark
muellerzr Oct 16, 2024
3c57947
Bookmark
muellerzr Oct 16, 2024
1d57bd8
Bookmark
muellerzr Oct 16, 2024
15e61f1
Actually implement
muellerzr Oct 16, 2024
928e927
Pass in kwarg explicitly
muellerzr Oct 16, 2024
b59c8f1
Adjust for if we do or don't have labels
muellerzr Oct 16, 2024
79f9479
Bookmark fix for od
muellerzr Oct 16, 2024
13f3369
bookmark
muellerzr Oct 16, 2024
8080f28
Fin
muellerzr Oct 16, 2024
13160e0
closer
muellerzr Oct 16, 2024
6fa155a
Negate accelerate grad accum div
muellerzr Oct 16, 2024
c2a705f
Fixup not training long enough
muellerzr Oct 17, 2024
ac04e61
Add in compute_loss to take full model output
muellerzr Oct 17, 2024
af8411b
Document
muellerzr Oct 17, 2024
a5fac5a
compute_loss -> compute_loss_fn
muellerzr Oct 17, 2024
39d8f28
Add a test
muellerzr Oct 17, 2024
4284930
Refactor
muellerzr Oct 17, 2024
932a491
Refactor
muellerzr Oct 17, 2024
2a6b038
Uncomment tests
muellerzr Oct 17, 2024
54d10de
Update tests/trainer/test_trainer.py
muellerzr Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading