Changing __repr__ in torchao to show quantized Linear #34202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunMarc
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Thanks for figuring out the issue @MekkCyber ! Left a few comments
SunMarc
reviewed
Oct 18, 2024
|
cc @SunMarc for review ! Thank you ! |
SunMarc
reviewed
Oct 18, 2024
SunMarc
reviewed
Oct 22, 2024
SunMarc
approved these changes
Oct 22, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Oct 28, 2024
| @@ -46,6 +45,25 @@ def find_parent(model, name): | |||
| return parent | |||
|
|
|||
|
|
|||
| def _quantization_type(weight): | |||
There was a problem hiding this comment.
do we want to put this on lru cache? Or is it smart enough to be fast ?
There was a problem hiding this comment.
I would think it's smart enough to be fast, but I will try to do a benchmark to test that
|
We can merge in the mean time 🤗 |
2015aroras
pushed a commit
to 2015aroras/transformers
that referenced
this pull request
Nov 15, 2024
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
BernardZach
pushed a commit
to innovationcore/transformers
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a model is quantized using TorchAO and then loaded, the representation of its Linear layers is expected to be different compared to the standard representation. This pull request (PR) modifies the representation of these Linear layers to match the format used in TorchAO's implementation : https://github.com/pytorch/ao/blob/main/torchao/quantization/quant_api.py
Before :
Linear(in_features=4096, out_features=4096, bias=False)After :
Who can review?
cc @SunMarc