Skip to content

Fix torch.fx issue related to the new loss_kwargs keyword argument #34380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Fix torch.fx issue related to the new loss_kwargs keyword argument #34380

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bd29f2
Fix FX
michaelbenayoun Oct 24, 2024
6448e75
Unskip tests
michaelbenayoun Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/utils/fx.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,7 +1416,7 @@ def keys(self, obj: "Proxy") -> Any:
your custom tracer.
"""
attribute = HFAttribute(obj, "keys")()
if obj.node.target == "**kwargs":
if obj.node.target.startswith("**"):
return attribute._metadata
return attribute

Expand Down
Loading