PATCH: add back n-dim device-mesh + fix tp hook registration #39693
+17
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device_mesh
have multiple dim #38949 but was by mistake reverted by Add ep #39501, we need this for upcoming accelerate/axolotl release.tensor+dtensor
in optimizer.step()TODO: Add proper plans for other TP models
TODO: Add correct plan merging even for distribute_and_shard
cc @ArthurZucker @SunMarc