Refactor check_auto_docstring using AST #41432
Merged
+243
−214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonigozlan
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
@ArthurZucker @Cyrilvallez Ready to be reviewed ;) |
Cyrilvallez
reviewed
Nov 11, 2025
Member
Cyrilvallez
left a comment
Cyrilvallez
left a comment
There was a problem hiding this comment.
Mostly trusting you on this, but <ci is not happy!
Member
Author
|
Thanks @Cyrilvallez , it should be good now! |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: glm4v, glm4v_moe |
yonigozlan
requested review from
Cyrilvallez
and removed request for
ArthurZucker
ArthurZucker
approved these changes
Nov 14, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Yes please the glm4 has been annoying haha. I think if CI is happy its enough of a test !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use AST instead of parsing the raw code to check for missing args in docstrings of class/functions using auto_docstring