Skip to content

Comments

[ci] Disable workflows with secrets and custom runners to run on fork#41515

Closed
HollowMan6 wants to merge 2 commits intohuggingface:mainfrom
HollowMan6:main
Closed

[ci] Disable workflows with secrets and custom runners to run on fork#41515
HollowMan6 wants to merge 2 commits intohuggingface:mainfrom
HollowMan6:main

Conversation

@HollowMan6
Copy link
Contributor

What does this PR do?

Skip those workflows by checking if the repository is owned by huggingface.

Tested by directly pushing to the fork: https://github.com/HollowMan6/transformers/commit/14be7f3c250c3ba1887877fc1df67b2e87559759

and opening a PR on the fork side:

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ydshieh

@Rocketknight1
Copy link
Member

I feel like we're probably not leaking secrets to everyone who forks the repo, so I'm not sure if this is necessary! cc @ydshieh to confirm

@HollowMan6
Copy link
Contributor Author

HollowMan6 commented Oct 13, 2025

I feel like it would be preferable to exclude those CIs that can't run in a fork, otherwise it's quite annoying to get those floods of error messages from GitHub if we modify something in the fork while we still want some CI to be working.

@Rocketknight1
Copy link
Member

Ah, that's a good point, sorry! I misread this as being about protecting secrets rather than improving the CI in forks

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 16, 2025

Yes, secret won't be leaked but triggered on forked repo is annoying.

Let me think if this PR is the best approach ...

Thank you for opening.

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 16, 2025

Screenshot 2025-10-16 163008

Maybe it's better to do this 🙏

putting the condition in many jobs doesn't really seem a very good / reliable approach to me.

@HollowMan6
Copy link
Contributor Author

Okay, yeah, I was meant to still get some CI working when we modify something in the fork. Now I double checked the CI and saw that almost all the CIs are disabled now... So this might not be necessary at all, and it's better to disable the GitHub Actions completely.

Thanks for your feedback anyway. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants