[ci] Disable workflows with secrets and custom runners to run on fork #41515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hollow Man <[email protected]>
The CI has been broken since May 2025 and no one seems to care about it https://github.com/huggingface/transformers/actions/runs/15233479801 Signed-off-by: Hollow Man <[email protected]>
|
I feel like we're probably not leaking secrets to everyone who forks the repo, so I'm not sure if this is necessary! cc @ydshieh to confirm |
|
I feel like it would be preferable to exclude those CIs that can't run in a fork, otherwise it's quite annoying to get those floods of error messages from GitHub if we modify something in the fork while we still want some CI to be working. |
|
Ah, that's a good point, sorry! I misread this as being about protecting secrets rather than improving the CI in forks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skip those workflows by checking if the repository is owned by
huggingface.Tested by directly pushing to the fork: HollowMan6@14be7f3
and opening a PR on the fork side:
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ydshieh