Add conditional checks to _check_and_adjust_attn_implementation()#41542
Merged
MekkCyber merged 1 commit intohuggingface:mainfrom Oct 14, 2025
zheliuyu:main
Merged
Add conditional checks to _check_and_adjust_attn_implementation()#41542MekkCyber merged 1 commit intohuggingface:mainfrom zheliuyu:main
MekkCyber merged 1 commit intohuggingface:mainfrom
zheliuyu:main
Conversation
Contributor
Author
|
@ArthurZucker @MekkCyber This PR is now ready for review. |
MekkCyber
approved these changes
Oct 13, 2025
Contributor
MekkCyber
left a comment
There was a problem hiding this comment.
Indeed ! thanks for fixing
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ngazagna-qc
pushed a commit
to ngazagna-qc/transformers
that referenced
this pull request
Oct 23, 2025
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To prevent unnecessary downloads by kernels, avoid installing kernels-community/flash-attn and kernels-community/vllm-flash-attn3 when attn_implementation=flash_attention_2 is specified for NPU.
test
script
Before
After