Skip to content

Conversation

@sywangyi
Copy link
Contributor

@sywangyi sywangyi commented Nov 6, 2025

fix pytest failure of following case
tests/generation/test_candidate_generator.py::TestUniversalSpeculativeDecoding::test_usd_vs_vanilla_sampling
tests/models/mistral/test_modeling_mistral.py::MistralIntegrationTest::test_speculative_generation
tests/models/qwen2/test_modeling_qwen2.py::Qwen2IntegrationTest::test_speculative_generation
tests/models/qwen3/test_modeling_qwen3.py::Qwen3IntegrationTest::test_speculative_generation
tests/models/whisper/test_modeling_whisper.py::WhisperModelIntegrationTests::test_speculative_decoding_non_distil
tests/models/whisper/test_modeling_whisper.py::WhisperModelIntegrationTests::test_speculative_decoding_distil
tests/models/sam2_video/test_modeling_sam2_video.py::Sam2VideoModelIntegrationTest::test_inference_propagate_on_streamed_video
tests/models/sam2_video/test_modeling_sam2_video.py::Sam2VideoModelIntegrationTest::test_inference_mask_generation_video_one_point_propagate_in_video_directly
tests/models/univnet/test_modeling_univnet.py::UnivNetModelIntegrationTests::test_integration

@sywangyi
Copy link
Contributor Author

sywangyi commented Nov 7, 2025

@vasqu could you help review it, thanks

Copy link
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditionals are getting longer and longer. Maybe it would be nicer to split these into cuda vs xpu and have proper explanations/comments at each point?

Edit: Not sure if the change in expected outputs is good, depends if things were faulty before (which I assume was the case) it's expected and was clarified under this review

Signed-off-by: Wang, Yi A <[email protected]>
@sywangyi
Copy link
Contributor Author

The conditionals are getting longer and longer. Maybe it would be nicer to split these into cuda vs xpu and have proper explanations/comments at each point?

Edit: Not sure if the change in expected outputs is good, depends if things were faulty before (which I assume was the case) it's expected and was clarified under this review

I split xpu out and add comment in the func

Copy link
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, lgtm let's just move this one if a bit and add a comment there

Signed-off-by: Wang, Yi A <[email protected]>
@github-actions
Copy link
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: qwen3

@vasqu vasqu enabled auto-merge (squash) November 12, 2025 12:25
@vasqu
Copy link
Contributor

vasqu commented Nov 12, 2025

Thx for iterating, merging now

@vasqu vasqu merged commit 58a3f8c into huggingface:main Nov 12, 2025
23 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants