-
Notifications
You must be signed in to change notification settings - Fork 31.2k
Make PegasusXModelTest run in less time
#42213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
vasqu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this so high in the first place 😭 take my approval
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
This test It test many cases (which is not a good approach for testing), and For this model , it's encoder-decoder, each of 2 layers. (But not sure if this play a significant role for slowness here.) |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: beit, big_bird, bigbird_pegasus, deformable_detr, pegasus_x, x_clip |
What does this PR do?
Saving 40 seconds for
The most significant one is
20 sec --> 4 sec.
Have no clear idea why this model use more time, but it's encoder-decoder, each of 2 layers ... and this test
test_model_outputs_equivalencehave many test cases, and being even slower if we haveoutput_attentions=True.Let's simply use smaller
batch_sizefor this modelBefore
After