Running huggingface_hub xet tests on PRs #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assafvayner
reviewed
Apr 10, 2025
bpronan
force-pushed
the
brian/hf-xet-tests
branch
from
6aa8a09 to
1d536f2
Compare
jgodlew
approved these changes
Apr 11, 2025
Contributor
jgodlew
left a comment
jgodlew
left a comment
There was a problem hiding this comment.
LGTM! We should probably check windows integration too.
seanses
reviewed
Apr 11, 2025
seanses
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding huggingface_hub xet tests to run on every PR and checkin.
We build the hf_xet wheel, clone huggingface_hub, and run the xet tests in huggingface_hub agains the new build.