Add support for fetching sensitive parts of actions from secrets #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaaldjorMike
changed the title
jswoods
approved these changes
Jul 2, 2024
Co-authored-by: Jestin Woods <[email protected]>
This was referenced Jul 3, 2024
triceras
pushed a commit
that referenced
this pull request
Mar 12, 2025
* Set initial TODOs. * Remove clear text apitoken. * Start implementing a secretMap. * Non-working commit. * Almost removed cleartext token. * Fix resolveSecrets. * Fix OpsGenie and HumioActionRepository. * Change TODO. * Remove constants. * update examples and crd. * Include namespace in lookup key. * Make keyRefs required. * Implement non-breaking solution. * Improve secret helpers. * Minor improvement. * Rebase to fix conflicts. * Add secretRef to PagerDutyProperties * wip * wip2 * wip3 * now it may work * wip * wip * wip * Update api/v1alpha1/humioaction_types.go Co-authored-by: Jestin Woods <[email protected]> * make manifests --------- Co-authored-by: fanicia <[email protected]> Co-authored-by: Scott Evtuch <[email protected]> Co-authored-by: Jestin Woods <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #479 #692 #691 #636