fix(next): misplaced className in cn functions
#1585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
huntabyte
approved these changes
Dec 28, 2024
Owner
huntabyte
left a comment
huntabyte
left a comment
There was a problem hiding this comment.
You're incredible.
Thank you!
Slartibartfass2
added a commit
to SE-UUlm/snowballr-frontend
that referenced
this pull request
Jan 2, 2025
…ompatibility issue In Svelte 5.16.0 the code of the shadcn components got broken due to a bug. This got fixed in huntabyte/shadcn-svelte#1585. To reproduce this I ran the shadcn cli update command locally (commit f06d2a1133c9df77902e62d4da79842a6b0af329). Due to a bug in the cli command, which was already reported in huntabyte/shadcn-svelte#1532 I had to adjust the code. The update command did overwrite some customizations we already made, which I undid.
Slartibartfass2
added a commit
to SE-UUlm/snowballr-frontend
that referenced
this pull request
Jan 6, 2025
…ompatibility issue In Svelte 5.16.0 the code of the shadcn components got broken due to a bug. This got fixed in huntabyte/shadcn-svelte#1585. To reproduce this I ran the shadcn cli update command locally (commit f06d2a1133c9df77902e62d4da79842a6b0af329). Due to a bug in the cli command, which was already reported in huntabyte/shadcn-svelte#1532 I had to adjust the code. The update command did overwrite some customizations we already made, which I undid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1582
This has always been an issue on next but I think it was only now noticed after the types for the
classprop changed in 5.16.0.Also
app-statemigration since$pagewill now show deprecated warning