Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: Stop returning the exception details to the API users #57

Merged
merged 1 commit into from
May 5, 2024

Conversation

hussein-awala
Copy link
Owner

Instead of returning the exception message and details in case of an error in the API query processing, we can generate a unique UUID to the exception and log it with ID, then return the ID to the API user, in this case, only the API admin can check the log to help the user understand the problem.

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 47.72%. Comparing base (22a2093) to head (59d9503).
Report is 1 commits behind head on main.

Files Patch % Lines
spark_on_k8s/api/app.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   45.65%   47.72%   +2.06%     
==========================================
  Files          29       30       +1     
  Lines        1198     1211      +13     
==========================================
+ Hits          547      578      +31     
+ Misses        651      633      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hussein-awala hussein-awala merged commit e0b56dc into main May 5, 2024
16 checks passed
@hussein-awala hussein-awala deleted the security/exception_details branch May 5, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant