Fixed a double credentials error #2059
Open
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the "use_authorization_to_get_token" option is on (which it by default is), credentials are sent twice if they are also present in the parameters. Additionally, client ID and secret are always overwritten in the parameters if this option is turned off, even in cases where the secret is generated and already added to the parameters (for example in `AppleResourceOwner` and `InstagramResourceOwner`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "use_authorization_to_get_token" option is on (which it by default is), credentials are sent twice if they are also present in the parameters.
In my case (HelloID), it results in a server error about sending credentials twice.
Additionally, client ID and secret are always overwritten in the parameters if this option is turned off, even in cases where the secret is generated and already added to the parameters (for example in
AppleResourceOwnerandInstagramResourceOwner).