Fix CI and tests #2061
Merged
Fix CI and tests #2061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing $ Fix "Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run" Fix PHPStan
willemverspyck
force-pushed
the
master
branch
from
6a93387 to
e5adb14
Compare
Contributor
Author
|
I tried to repair the PHP Stan errors with small changes and by removing code that was needed for Symfony 5, that is not supported anymore. I still have to do more tests with my changes, but if others can also test my branche, please do 👍 Then we can go forward and allow Symfony 8. |
Member
|
Seems good to me. |
Contributor
Author
|
I did more tests and this works for me. Please merge @XWB 😊 |
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
method_exists($this->requestStack, 'getSession'),method_exists($this->requestStack, 'getMainRequest')ormethod_exists($extension, 'addAuthenticatorFactory'), as these methods are available in all supported Symfony versions.