Support Symfony 8 and remove code of unsupported Symfony versions #2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Symfony Monolog Allow Doctrine version 3
willemverspyck
force-pushed
the
master
branch
from
9fe68ce to
21e194e
Compare
Member
|
👍 Thanks |
Closed
stloyd
reviewed
Jan 15, 2026
| { | ||
| public static function get(Request $request, string $field): ?string | ||
| { | ||
| return $request->query->get($field) ?? $request->request->get($field); |
Collaborator
There was a problem hiding this comment.
In theory, it could be BC break if someone used a "hidden" definition like attributes on request.
Contributor
Author
There was a problem hiding this comment.
Yes, I had the same doubts. But in the official OAuth flow, only GET and POST is allowed. If it's a real problem, we could add "attributes" again and throw an deprecation, when it's used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request->get()methods (Fix Since symfony/http-foundation 7.4: Request::get() is deprecated #2062).OAuthListenerthat was part of old authetication system, part of Symfony 5.