-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker-compose.yml #5
base: master
Are you sure you want to change the base?
Conversation
docker-compose.yml
Outdated
@@ -1,51 +1,50 @@ | |||
version: '2' | |||
version: '3.6' | |||
services: | |||
db_camunda: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postgres_camunda
docker-compose.yml
Outdated
redis: | ||
internal: true | ||
name: redis | ||
net: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hydra, it's a standart network name for our practice with docker-compose
docker-compose.yml
Outdated
env_file: ".env" | ||
restart: unless-stopped | ||
command: server /opt/minio --address "0.0.0.0:9001" | ||
env_file: .env | ||
environment: | ||
- TZ=${TZ} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that passing of TZ env var is needed for this general purpose quick start example. TZ does not needed in .env file too.
docker-compose.yml
Outdated
restart: always | ||
env_file: ".env" | ||
restart: unless-stopped | ||
env_file: .env | ||
environment: | ||
- TZ=${TZ} | ||
- RAILS_ENV=production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "production" really not the default value for rails app environment? I see, there is not RAILS_ENV env var in docker image, but what about defaults for the application itself?
docker-compose.yml
Outdated
homs: | ||
image: latera/homs:2.7.0 | ||
image: hydrabilling/homs:2.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use latest version in this example docker-compose? I'm talking about not only about homs, but also about camunda and minio (redis is already used with latest version).
.env
Outdated
SECRET_KEY_BASE=euciey3AitaevohReel3yee3AihoeSagroongaiAhaighoh2vahdee3ahsah6fu8baes4kee6zieTae6oz | ||
|
||
TZ=Europe/Moscow | ||
SECRET_KEY_BASE=secret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HOMS_SECRET_KEY_BASE
docker-compose.yml
Outdated
WAIT_FOR_TIMEOUT: 120 | ||
- DB_USERNAME=$BPM_DB_USER | ||
- DB_PASSWORD=$BPM_DB_PASSWORD | ||
- LOG_LVL=info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to .env
No description provided.