Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose.yml #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

bigotalks
Copy link
Contributor

No description provided.

@@ -1,51 +1,50 @@
version: '2'
version: '3.6'
services:
db_camunda:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postgres_camunda

redis:
internal: true
name: redis
net:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hydra, it's a standart network name for our practice with docker-compose

docker-compose.yml Show resolved Hide resolved
env_file: ".env"
restart: unless-stopped
command: server /opt/minio --address "0.0.0.0:9001"
env_file: .env
environment:
- TZ=${TZ}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that passing of TZ env var is needed for this general purpose quick start example. TZ does not needed in .env file too.

restart: always
env_file: ".env"
restart: unless-stopped
env_file: .env
environment:
- TZ=${TZ}
- RAILS_ENV=production
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "production" really not the default value for rails app environment? I see, there is not RAILS_ENV env var in docker image, but what about defaults for the application itself?

docker-compose.yml Show resolved Hide resolved
homs:
image: latera/homs:2.7.0
image: hydrabilling/homs:2.7.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use latest version in this example docker-compose? I'm talking about not only about homs, but also about camunda and minio (redis is already used with latest version).

.env Outdated
SECRET_KEY_BASE=euciey3AitaevohReel3yee3AihoeSagroongaiAhaighoh2vahdee3ahsah6fu8baes4kee6zieTae6oz

TZ=Europe/Moscow
SECRET_KEY_BASE=secret
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HOMS_SECRET_KEY_BASE

WAIT_FOR_TIMEOUT: 120
- DB_USERNAME=$BPM_DB_USER
- DB_PASSWORD=$BPM_DB_PASSWORD
- LOG_LVL=info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to .env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants