Fix race condition that was causing a crash in time observer

[jbaudanza]

I was only able to reproduce this crash once, but I took a screenshot:

The root cause is that audioPlayer is set to nil on the react-native thread, not the main thread. So, even though we change for nil on line 338, there's no guarantee it's still not nil on line 340.

This PR will wrap the audioPlayer = nil mutation in DispatchQueue.main.async.

I also changed the time observer to keep a weak reference to self, because the apple docs state this is important to prevent a retain cycle: https://developer.apple.com/documentation/avfoundation/avplayer/1385829-addperiodictimeobserverforinterv?language=swift

[Copilot]

Pull Request Overview

This PR fixes a race condition by ensuring audioPlayer is set to nil on the main thread and updates the periodic time observer to use a weak reference to self to avoid retain cycles.

• Wrapped audioPlayer = nil (and related pause/removeObserver/resolve) in DispatchQueue.main.async
• Changed time observer closure to capture self weakly and guard unwrapping to prevent retain cycles

Comments suppressed due to low confidence (2)

ios/RNAudioRecorderPlayer.swift:415

• [nitpick] Unnecessary semicolon in Swift. Removing the semicolon keeps the style consistent with the rest of the file.

self.audioPlayer = nil;

ios/RNAudioRecorderPlayer.swift:338

• [nitpick] You might also capture audioPlayerItem in the guard (let item = self.audioPlayerItem) to avoid multiple self accesses and guard against it being nil during the time observer callback.

guard let self = self, let audioPlayer = self.audioPlayer else { return }

[hyochan]

LGTM!