feat: support coorelate logs in trace windows

- Support searching coorelate span log in trace windows Ref: hdx-1181
hyperdxio · Feb 11, 2025 · 7c2c758 · 7c2c758
1 parent ff66cc3
commit 7c2c758
Show file tree

Hide file tree

Showing 5 changed files with 313 additions and 183 deletions.
diff --git a/.changeset/lemon-walls-collect.md b/.changeset/lemon-walls-collect.md
@@ -0,0 +1,5 @@
+---
+"@hyperdx/common-utils": patch
+---
+
+add correlate log in trace waterfall chart
diff --git a/packages/app/src/TimelineChart.tsx b/packages/app/src/TimelineChart.tsx
@@ -334,6 +334,7 @@ type Row = {
   label: React.ReactNode;
   events: TimelineEventT[];
   style?: any;
+  type?: string;
   className?: string;
 };
 

diff --git a/packages/app/src/components/DBTracePanel.tsx b/packages/app/src/components/DBTracePanel.tsx
@@ -1,6 +1,7 @@
 import { useEffect, useState } from 'react';
 import { parseAsJson, parseAsString, useQueryState } from 'nuqs';
 import { useForm } from 'react-hook-form';
+import { SourceKind } from '@hyperdx/common-utils/dist/types';
 import {
   ActionIcon,
   Box,
@@ -56,7 +57,7 @@ export default function DBTracePanel({
 
   const [traceRowWhere, setTraceRowWhere] = useQueryState(
     'traceRowWhere',
-    parseAsString,
+    parseAsJson<{ id: string; type: string }>(),
   );
 
   const {
@@ -186,13 +187,14 @@ export default function DBTracePanel({
       )}
       <Divider my="sm" />
       {sourceFormModalOpened && <TableSourceForm sourceId={watch('source')} />}
-      {traceSourceData?.kind === 'trace' && (
+      {traceSourceData?.kind === SourceKind.Trace && (
         <DBTraceWaterfallChartContainer
           traceTableModel={traceSourceData}
+          logTableModel={parentSourceData}
           traceId={traceId}
           dateRange={dateRange}
           focusDate={focusDate}
-          highlightedRowWhere={traceRowWhere}
+          highlightedRowWhere={traceRowWhere?.id}
           onClick={setTraceRowWhere}
         />
       )}
@@ -202,7 +204,14 @@ export default function DBTracePanel({
           <Text size="sm" c="dark.2" my="sm">
             Span Details
           </Text>
-          <RowDataPanel source={traceSourceData} rowId={traceRowWhere} />
+          <RowDataPanel
+            source={
+              traceRowWhere?.type === SourceKind.Log && parentSourceData
+                ? parentSourceData
+                : traceSourceData
+            }
+            rowId={traceRowWhere?.id}
+          />
         </>
       )}
       {traceSourceData != null && !traceRowWhere && (