Skip to content

feat: Add # of planned read rows on search #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2024
Merged

feat: Add # of planned read rows on search #538

merged 1 commit into from
Dec 23, 2024

Conversation

teeohhem
Copy link
Contributor

@teeohhem teeohhem commented Dec 23, 2024 •
edited
Loading

Utilizes the EXPLAIN ESTIMATE feature and queries CH to return # of rows that will be potentially read.

Ref: HDX-1136

Before:
image

After:
image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 90f3023

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MikeShi42
MikeShi42 reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can share a screenshot of the change (and frontend diffs generally), that'd be incredibly helpful!

@teeohhem
feat: Add # of planned read rows
bc6ce08 
Utilizes the EXPLAIN ESTIMATE feature and queries CH to return # of rows that will be potentially read.

Ref: HDX-1136
MikeShi42
MikeShi42 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@teeohhem teeohhem merged commit 1088682 into v2 Dec 23, 2024
4 checks passed
@teeohhem teeohhem deleted the tom/HDX-1136 branch December 23, 2024 22:39
@ernestii ernestii mentioned this pull request Mar 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeShi42 MikeShi42 MikeShi42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teeohhem @MikeShi42