Skip to content

fix: no need to show field dropdown for all 'count' agg functions #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 24, 2024
Merged

fix: no need to show field dropdown for all 'count' agg functions #541

merged 3 commits into from
Dec 24, 2024

Conversation

wrn14897
Copy link
Member

@wrn14897 wrn14897 commented Dec 23, 2024 •
edited
Loading

Screenshot 2024-12-23 at 3 12 25 PM

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d00754a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

wrn14897
wrn14897 commented Dec 23, 2024
View reviewed changes
packages/app/src/ChartUtils.tsx
@@ -581,261 +589,6 @@ export function FieldSelect({
);
}

export function ChartSeriesForm({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used

@kodiakhq kodiakhq bot merged commit cc2a3d4 into main Dec 24, 2024
4 checks passed
@kodiakhq kodiakhq bot deleted the warren/revisit-count-agg-charting-ui branch December 24, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeShi42 MikeShi42 MikeShi42 approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrn14897 @MikeShi42