style: use common utils package (api and app) #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wrn14897
changed the title
wrn14897
changed the title
MikeShi42
previously approved these changes
Jan 17, 2025
wrn14897
force-pushed
the
warren/use-common-utils-pkg
branch
from
06151b3 to
92a6fed
Compare
LYHuang
approved these changes
Jan 21, 2025
MikeShi42
reviewed
Mar 8, 2025
| }; | ||
|
|
||
| export const metadata = new Metadata(); | ||
| export const getMetadata = () => _getMetadata(getClickhouseClient()); |
There was a problem hiding this comment.
why did we change this from a singleton? aren't we creating a ton of new metadata objects without reason?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.