Version common-utils + Setup int test environment
#566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
wrn14897
previously approved these changes
Jan 22, 2025
github-actions
bot
force-pushed
the
changeset-release/v2
branch
from
8d9b06c to
fa38597
Compare
wrn14897
changed the title
common-utils + Setup int test environment
wrn14897
reviewed
Jan 22, 2025
| @@ -41,12 +41,15 @@ dev-int-build: | |||
|
|
|||
| .PHONY: dev-int | |||
| dev-int: | |||
| docker compose -p int -f ./docker-compose.ci.yml run --rm api dev:int $(FILE) | |||
There was a problem hiding this comment.
The dx should be the same (run make dev-int FILE=blabla)
wrn14897
reviewed
Jan 22, 2025
| # - 6379:6379 | ||
| networks: | ||
| - internal | ||
| api: |
There was a problem hiding this comment.
move this out of docker (since we need to test common-utils together)
teeohhem
reviewed
Jan 22, 2025
| @@ -346,7 +346,7 @@ export class ClickhouseClient { | |||
| } else if (isNode) { | |||
| const { createClient } = await import('@clickhouse/client'); | |||
| const _client = createClient({ | |||
| host: this.host, | |||
| url: this.host, | |||
There was a problem hiding this comment.
just curious about this change...related to the PR or a drive-by fix?
There was a problem hiding this comment.
its a drive-by style change. the flag should work either way. saw the api deprecation warning (https://github.com/ClickHouse/clickhouse-js/blob/1ebdd39203730bb99fad4c88eac35d9a5e96b34a/CHANGELOG.md?plain=1#L258)
LYHuang
approved these changes
Jan 22, 2025
teeohhem
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to v2, this PR will be updated.
Releases
@hyperdx/[email protected]
Patch Changes