Skip to content

feat: render sample logs in SavedSearch alert#573

Merged
kodiakhq[bot] merged 6 commits intov2from
warren/revisit-checkalerts-pt1
Jan 27, 2025
Merged

feat: render sample logs in SavedSearch alert#573
kodiakhq[bot] merged 6 commits intov2from
warren/revisit-checkalerts-pt1

Conversation

@wrn14897
Copy link
Member

@wrn14897 wrn14897 commented Jan 24, 2025

Screenshot 2025-01-24 at 5 54 42 PM

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: 2d4412e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +515 to +520
const lines = raw.split('\n');

truncatedResults = truncateString(
lines.map(line => truncateString(line, MAX_MESSAGE_LENGTH)).join('\n'),
2500,
);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there isn't a dedicated 'Body' field, it makes more sense to show whatever users put in the select field. We might revisit the logic here

Copy link
Contributor

@LYHuang LYHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@dhable dhable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kodiakhq kodiakhq bot merged commit 406787a into v2 Jan 27, 2025
4 checks passed
@kodiakhq kodiakhq bot deleted the warren/revisit-checkalerts-pt1 branch January 27, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants