feat(metrics): Support multiple OTEL tables #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the source configuration dialog for metrics to handle multiple, supported OTEL metric tables in a single form. Ref: HDX-1390
teeohhem
reviewed
Feb 12, 2025
| } | ||
| } | ||
| } catch (e) { | ||
| console.error(e); |
There was a problem hiding this comment.
nit: Should probably toast here with e.message
There was a problem hiding this comment.
Added just below but left in the console.error so we also output more context for debugging later.
Added notification toast when catching error trying to validate the table.
🦋 Changeset detectedLatest commit: 365f611 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MikeShi42
reviewed
Feb 12, 2025
| const connectionId = watch(`connection`); | ||
|
|
||
| const [showOptionalFields, setShowOptionalFields] = useState(false); | ||
| useEffect(() => { | ||
| setValue('timestampValueExpression', ''); |
There was a problem hiding this comment.
can we set this to TimeUnix or StartTimeUnix?
MikeShi42
approved these changes
Feb 12, 2025
kodiakhq
bot
deleted the
dhable/hdx-1390-otel-metrics-under-one-source
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the source configuration dialog for metrics to handle multiple, supported OTEL metric tables in a single form.
Ref: HDX-1390