-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for generic webhooks in Team page #612
Conversation
Adds support for the user to add and view generic webhooks. Ref: HDX-1396
|
packages/app/src/TeamPage.tsx
Outdated
@@ -700,6 +700,17 @@ function CreateWebhookForm({ | |||
<form onSubmit={form.handleSubmit(onSubmit)}> | |||
<Stack mt="sm"> | |||
<Text>Create Webhook</Text> | |||
<Radio.Group | |||
name="service" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to register this to the form to persist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's a better approach. Its a bit clunky with radio buttons, but I've made the change. It'll persist either way, but using the form hook is cleaner as to not add state outside of the form object itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i misread the original diff, but this is a bit cleaner thank you :)
Adds support for the user to add and view generic webhooks.
Ref: HDX-1396