Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for generic webhooks in Team page #612

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

teeohhem
Copy link

Adds support for the user to add and view generic webhooks.

Ref: HDX-1396

Adds support for the user to add and view generic webhooks.

Ref: HDX-1396
Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: e714fed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -700,6 +700,17 @@ function CreateWebhookForm({
<form onSubmit={form.handleSubmit(onSubmit)}>
<Stack mt="sm">
<Text>Create Webhook</Text>
<Radio.Group
name="service"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to register this to the form to persist?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's a better approach. Its a bit clunky with radio buttons, but I've made the change. It'll persist either way, but using the form hook is cleaner as to not add state outside of the form object itself.

Copy link
Contributor

@MikeShi42 MikeShi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i misread the original diff, but this is a bit cleaner thank you :)

@kodiakhq kodiakhq bot merged commit 434ae89 into v2 Feb 12, 2025
4 checks passed
@kodiakhq kodiakhq bot deleted the tom/webhooks-hdx-1396 branch February 12, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants