Skip to content

fix: Better loading state for Client Sessions page #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ernestii
Copy link
Contributor

Address this issue:

when I visit sessions page and select the source, the instruction shows up and I can see sessions once they are loaded.

Improves loading state handling and checks for source type.

Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: 178c488

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdx-v2-oss-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 4:26pm

@ernestii ernestii changed the title 123 fix: Better loading state for Client Sessions page Apr 30, 2025
@ernestii ernestii requested a review from Copilot April 30, 2025 02:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refines the loading and validation state on the Client Sessions page so that users see a more responsive spinner and appropriate messaging based on both sessions and source loading states.

  • Added a new isPending flag (isSessionSourceLoading) to the useSource hook.
  • Updated conditional rendering to show a spinner if either sessions or session source are loading and refactored the UI messaging for invalid session sources and empty sessions.

@kodiakhq kodiakhq bot merged commit 66eca90 into v2 Apr 30, 2025
5 of 6 checks passed
@kodiakhq kodiakhq bot deleted the ernest/hdx-1443-bug-should-display-loading-indicator-instead-of-instructions-2 branch April 30, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants